Skip to content

[rb] remove guard from working test #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[rb] remove guard from working test #15307

wants to merge 10 commits into from

Conversation

@aguspe
Copy link
Contributor

@aguspe aguspe commented Feb 19, 2025 •
edited
Loading

User description

Motivation and Context

This PR removes the guard from a firefox text that is working again on the action builder spec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Tests, Bug fix

Description

  • Added exception for Firefox in two test cases due to known issue.

  • Updated test descriptions to include reasons for exceptions.

  • Minor formatting adjustments in test files for consistency.

Changes walkthrough 📝

Relevant files
Tests
network_spec.rb
Add Firefox exception to 'provides response' test               

rb/spec/integration/selenium/webdriver/bidi/network_spec.rb

  • Added exception for Firefox in the 'provides response' test.
  • Included a link to the related GitHub issue.
    		• +2/-1     
    network_spec.rb
    Add Firefox exception and format adjustments in tests       

    rb/spec/integration/selenium/webdriver/network_spec.rb

  • Added exception for Firefox in the 'adds a response handler' test.
  • Included a link to the related GitHub issue.
  • Adjusted formatting for consistency in test descriptions.
    		• +6/-4     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 19, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Style

    Inconsistent hash formatting in request body assignment. The added line uses unnecessary parentheses and spaces around the hash.

    request.body = ({ test: 'example' })

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 19, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Learned
    best practice
    Use consistent hash literal syntax with proper spacing for better code readability

    The hash literal syntax is inconsistent and could be improved for better
    readability. Use spaces after colons in hash literals consistently.

    rb/spec/integration/selenium/webdriver/network_spec.rb [163]

    -request.body = ({test: 'example'})
+request.body = { test: 'example' }
    • Apply this suggestion
    Suggestion importance[1-10]: 6
    		Low
    General
    Improve hash literal formatting consistency

    Add space after opening curly brace and before closing curly brace in the hash
    literal to improve code readability and follow Ruby style conventions.

    rb/spec/integration/selenium/webdriver/network_spec.rb [163]

    +request.body = ({ test: 'example' })
 
-
    • Apply this suggestion
    Suggestion importance[1-10]: 3

    __

    Why: The suggestion addresses minor code style inconsistency in hash literal formatting, which slightly improves code readability but has no functional impact.

    		Low
    Fix hash parameter indentation

    Fix indentation alignment in the 'except' hash to maintain consistent spacing
    with other hash parameters.

    rb/spec/integration/selenium/webdriver/network_spec.rb [266-267]

     except: { browser: :firefox,
-               reason: 'https://github.com/w3c/webdriver-bidi/issues/747' }
+          reason: 'https://github.com/w3c/webdriver-bidi/issues/747' }

    [To ensure code accuracy, apply this suggestion manually]

    Suggestion importance[1-10]: 3

    __

    Why: The suggestion proposes a minor formatting improvement for consistent indentation in the hash parameters, which enhances code readability but doesn't affect functionality.

    		Low
    • Update

    @aguspe aguspe changed the title Rb remove guard from working text [rb] remove guard from working text Feb 19, 2025
    @aguspe aguspe changed the title [rb] remove guard from working text [rb] remove guard from working test Feb 19, 2025
    @VietND96 VietND96 deleted the branch SeleniumHQ:release-preparation-4.29.0 February 19, 2025 20:12
    @VietND96 VietND96 closed this Feb 19, 2025
    @VietND96
    Copy link
    Member

    VietND96 commented Feb 19, 2025

    @aguspe, oops, sorry about this, it closed automatically when I merged the release PR.
    Can it be reopened by changing the base to trunk? We will continue to make test more stable on trunk.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @aguspe @VietND96